[webkit-reviews] review granted: [Bug 198889] [LFC][Floats] Add bottom value to FloatingState::Constraints : [Attachment 372198] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 16 12:19:15 PDT 2019

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 198889: [LFC][Floats] Add bottom value to FloatingState::Constraints

Attachment 372198: Patch


--- Comment #5 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 372198
  --> https://bugs.webkit.org/attachment.cgi?id=372198

View in context: https://bugs.webkit.org/attachment.cgi?id=372198&action=review

> Source/WebCore/layout/LayoutUnits.h:63
> +    void moveBy(LayoutSize);

IntPoint calls this move. Generally it would be good to match existing
interfaces unless there is a good reason not to.

More information about the webkit-reviews mailing list