[webkit-reviews] review granted: [Bug 198891] [LFC][IFC] Intruding float may prevent adding any inline box : [Attachment 372199] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jun 16 12:09:27 PDT 2019
Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 198891: [LFC][IFC] Intruding float may prevent adding any inline box
https://bugs.webkit.org/show_bug.cgi?id=198891
Attachment 372199: Patch
https://bugs.webkit.org/attachment.cgi?id=372199&action=review
--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 372199
--> https://bugs.webkit.org/attachment.cgi?id=372199
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=372199&action=review
> Source/WebCore/layout/LayoutUnits.h:62
> + static Point max() { return Point(LayoutUnit::max(), LayoutUnit::max());
}
return { .. } would work I suppose.
> Source/WebCore/layout/LayoutUnits.h:64
> void moveBy(LayoutPoint);
Not from this patch but moving a Point by a Point is not good semantically. It
would be if you had to explicitly turn Point to Size first. This is how
IntPoint etc work.
More information about the webkit-reviews
mailing list