[webkit-reviews] review granted: [Bug 198901] [LFC][IFC] Decouple baseline ascent/descent and baseline offset. : [Attachment 372215] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 16 11:59:52 PDT 2019

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 198901: [LFC][IFC] Decouple baseline ascent/descent and baseline offset.

Attachment 372215: Patch


--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 372215
  --> https://bugs.webkit.org/attachment.cgi?id=372215

View in context: https://bugs.webkit.org/attachment.cgi?id=372215&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBox.h:54
> +    // baseline offset from line logical top. Note that offset does not
necessarily equal to ascent.

Start with capital letter.

This could use some ascii art!

More information about the webkit-reviews mailing list