[webkit-reviews] review granted: [Bug 198875] [MediaStream] Avoid roundoff error when setting AVCapture min/max frame rate : [Attachment 372165] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 15 18:39:18 PDT 2019


youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 198875: [MediaStream] Avoid roundoff error when setting AVCapture min/max
frame rate
https://bugs.webkit.org/show_bug.cgi?id=198875

Attachment 372165: Patch

https://bugs.webkit.org/attachment.cgi?id=372165&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 372165
  --> https://bugs.webkit.org/attachment.cgi?id=372165
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372165&action=review

> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:339
> +		   [device() setActiveVideoMaxFrameDuration:
frameRateRange.maxFrameDuration];

Probably frameDuration instead of frameRateRange.maxFrameDuration.


More information about the webkit-reviews mailing list