[webkit-reviews] review granted: [Bug 198829] [GTK] Stop accessing GdkEvent fields when possible : [Attachment 372116] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 14 06:48:24 PDT 2019

Michael Catanzaro <mcatanzaro at igalia.com> has granted Ludovico de Nittis
<ludovico.denittis at collabora.com>'s request for review:
Bug 198829: [GTK] Stop accessing GdkEvent fields when possible

Attachment 372116: Patch


--- Comment #12 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 372116
  --> https://bugs.webkit.org/attachment.cgi?id=372116

View in context: https://bugs.webkit.org/attachment.cgi?id=372116&action=review


> Source/WebCore/platform/gtk/PlatformMouseEventGtk.cpp:58
> -    m_position = IntPoint((int)event->x, (int)event->y);
> -    m_globalPosition = IntPoint((int)event->x_root, (int)event->y_root);
> +    m_position = IntPoint((int)x, (int)y);
> +    m_globalPosition = IntPoint((int)rootX, (int)rootY);

Preexisting problem, but since you're modifying these lines, change them to
static_cast because C-style casts aren't allowed in WebKit.

More information about the webkit-reviews mailing list