[webkit-reviews] review granted: [Bug 198842] Move Synthetic Editing Commands to behind an experimental feature flag : [Attachment 372081] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 198842: Move Synthetic Editing Commands to behind an experimental feature
flag
https://bugs.webkit.org/show_bug.cgi?id=198842

Attachment 372081: Patch

https://bugs.webkit.org/attachment.cgi?id=372081&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 372081
  --> https://bugs.webkit.org/attachment.cgi?id=372081
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372081&action=review

Now this is a setting, you can write tests for it (if we have the plumbing).

> Source/WebKitLegacy/mac/WebView/WebView.mm:3165
> +   
RuntimeEnabledFeatures::sharedFeatures().setSyntheticEditingCommandsEnabled([pr
eferences syntheticEditingCommandsEnabled]);

Nope!