[webkit-reviews] review granted: [Bug 198784] IntersectionObserver rootMargin detection fails when `root` is an element : [Attachment 372076] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 13 13:23:59 PDT 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ali Juma
<ajuma at chromium.org>'s request for review:
Bug 198784: IntersectionObserver rootMargin detection fails when `root` is an
element
https://bugs.webkit.org/show_bug.cgi?id=198784

Attachment 372076: Patch

https://bugs.webkit.org/attachment.cgi?id=372076&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 372076
  --> https://bugs.webkit.org/attachment.cgi?id=372076
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372076&action=review

> Source/WebCore/rendering/RenderObject.cpp:990
>      VisibleRectContext context;
> +    context.m_options.add(VisibleRectContextOption::ApplyContainerClip);

How about:
VisibleRectContext context(false, false, {
VisibleRectContextOption::ApplyContainerClip });


More information about the webkit-reviews mailing list