[webkit-reviews] review granted: [Bug 198832] twitch.tv: embedded video hovers down the screen when scrolling on iPad : [Attachment 372056] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 198832: twitch.tv: embedded video hovers down the screen when scrolling on
iPad
https://bugs.webkit.org/show_bug.cgi?id=198832

Attachment 372056: patch

https://bugs.webkit.org/attachment.cgi?id=372056&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 372056
  --> https://bugs.webkit.org/attachment.cgi?id=372056
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372056&action=review

>> Source/WebCore/rendering/RenderLayer.cpp:2522
>> +		       
paintParent->setDescendantsNeedUpdateBackingAndHierarchyTraversal();
> 
> This might be a stupid question, but... In the case where paintParent is
null, shouldn't we still setDescendantsNeedUpdateBackingAndHierarchyTraversal()
on ourselves?
> 
> auto* layer = paintOrderParent() ? paintOrderParent() : this;
> layer->setDescendantsNeedUpdateBackingAndHierarchyTraversal();

paintOrderParent() is only null for RenderView, so that should never hit this
code.