[webkit-reviews] review denied: [Bug 126124] [cairo] Entering text into forms on github.com creates a trapezoid artifact : [Attachment 372047] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 126124: [cairo] Entering text into forms on github.com creates a trapezoid
artifact
https://bugs.webkit.org/show_bug.cgi?id=126124

Attachment 372047: Patch

https://bugs.webkit.org/attachment.cgi?id=372047&action=review




--- Comment #21 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 372047
  --> https://bugs.webkit.org/attachment.cgi?id=372047
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372047&action=review

Thanks so much for fixing this!

You forgot the ChangeLog entry.

> Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:1276
> -    cairo_antialias_t savedAntialiasRule = cairo_get_antialias(cr);
> -    cairo_set_antialias(cr, CAIRO_ANTIALIAS_NONE);
> -    cairo_clip(cr);
> +//	 cairo_antialias_t savedAntialiasRule = cairo_get_antialias(cr);
> +//	 cairo_set_antialias(cr, CAIRO_ANTIALIAS_NONE);
> +//	 cairo_clip(cr);
> +    doClipWithAntialias(cr, CAIRO_ANTIALIAS_NONE);

You also forgot to remove the original code. Try again. :)