[webkit-reviews] review denied: [Bug 198797] Ensure ITP state is relayed to Network Process on restart : [Attachment 372004] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 13 06:22:31 PDT 2019

Sam Weinig <sam at webkit.org> has denied Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 198797: Ensure ITP state is relayed to Network Process on restart

Attachment 372004: Patch


--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 372004
  --> https://bugs.webkit.org/attachment.cgi?id=372004

View in context: https://bugs.webkit.org/attachment.cgi?id=372004&action=review

> Source/WebKit/UIProcess/WebProcessPool.cpp:637
> +	      
ed(true), 0);

To avoid the unnecessary extra IPC, can this be added to
NetworkProcessCreationParameters? What is the purpose of predicating this on
!withWebsiteDataStore && !m_websiteDataStore?

> Source/WebKit/UIProcess/WebProcessPool.cpp:682
> +    // Make sure the newly-spawned NetworkProcess is in the right ITP state.
> +    if (m_itpIsEnabled && !m_websiteDataStore)
> +	  
ed(true), 0);

This seems like duplicate work given you also call this in

> Source/WebKit/UIProcess/WebProcessPool.h:730
> +    bool m_itpIsEnabled { false };

It seems like this might make more sense as a property of the WebSiteDataStore,
rather than the network process itself.

More information about the webkit-reviews mailing list