[webkit-reviews] review granted: [Bug 198791] [Nicosia] Add SceneIntegration : [Attachment 371983] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 198791: [Nicosia] Add SceneIntegration
https://bugs.webkit.org/show_bug.cgi?id=198791

Attachment 371983: Patch

https://bugs.webkit.org/attachment.cgi?id=371983&action=review




--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 371983
  --> https://bugs.webkit.org/attachment.cgi?id=371983
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371983&action=review

> Source/WebCore/platform/graphics/nicosia/NicosiaSceneIntegration.h:47
> +    SceneIntegration();

Why is this needed?

> Source/WebCore/platform/graphics/nicosia/NicosiaSceneIntegration.h:48
> +    SceneIntegration(Client&);

explicit

> Source/WebCore/platform/graphics/nicosia/NicosiaSceneIntegration.h:59
> +	   UpdateScope(Ref<SceneIntegration>&&);

explicit

> Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:56
> +    , m_sceneIntegration(*new Nicosia::SceneIntegration(*this))

I would add a Nicosia::SceneIntegration::create method returning a Ref

> Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h:44
> +#if USE(COORDINATED_GRAPHICS)
> +#include <WebCore/NicosiaSceneIntegration.h>
> +#endif

If NicosiaSceneIntegration is specific to COORDINATED_GRAPHICS I would move the
guard to the header instead (and the cpp)