[webkit-reviews] review granted: [Bug 198811] [WebGL] ANGLE Extension directive location incorrectly enforced for webgl 1.0 : [Attachment 371993] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Justin Fan <justin_fan at apple.com>'s
request for review:
Bug 198811: [WebGL] ANGLE Extension directive location incorrectly enforced for
webgl 1.0
https://bugs.webkit.org/show_bug.cgi?id=198811

Attachment 371993: Patch

https://bugs.webkit.org/attachment.cgi?id=371993&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 371993
  --> https://bugs.webkit.org/attachment.cgi?id=371993
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371993&action=review

> LayoutTests/webgl/webgl-extension-directive-location-no-error.html:2
> +<p>Ensure that if a shader extension directive is specified after
non-preprocessor symbols, compilation succeeds.</p>

I think you should mention that if it fails, output will be in the console log.