[webkit-reviews] review granted: [Bug 195011] [WPE][GTK] Deprecate WebSQL APIs : [Attachment 362916] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 12 05:01:55 PDT 2019
Carlos Garcia Campos <cgarcia at igalia.com> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 195011: [WPE][GTK] Deprecate WebSQL APIs
https://bugs.webkit.org/show_bug.cgi?id=195011
Attachment 362916: Patch
https://bugs.webkit.org/attachment.cgi?id=362916&action=review
--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 362916
--> https://bugs.webkit.org/attachment.cgi?id=362916
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=362916&action=review
> Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp:323
> + * Deprecated: 2.24. WebSQL is no longer supported. Use IndexedDB
instead.
2.26 now
> Source/WebKit/UIProcess/API/gtk/WebKitWebsiteData.h:43
> + * @WEBKIT_WEBSITE_DATA_WEBSQL_DATABASES: WebSQL databases (deprecated).
WebSQL databases. Deprecated 2.26
> Source/WebKit/UIProcess/API/wpe/WebKitWebsiteData.h:43
> - * @WEBKIT_WEBSITE_DATA_WEBSQL_DATABASES: WebSQL databases.
> + * @WEBKIT_WEBSITE_DATA_WEBSQL_DATABASES: WebSQL databases (deprecated).
Ditto.
> Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:156
> +ALLOW_DEPRECATED_DECLARATIONS_BEGIN
> GUniquePtr<char> webSQLDirectory(g_build_filename(Test::dataDirectory(),
"websql", nullptr));
> g_assert_cmpstr(webSQLDirectory.get(), ==,
webkit_website_data_manager_get_websql_directory(test->m_manager));
> test->runJavaScriptAndWaitUntilFinished("db =
openDatabase(\"TestDatabase\", \"1.0\", \"TestDatabase\", 1);", nullptr);
> g_assert_true(g_file_test(webSQLDirectory.get(), G_FILE_TEST_IS_DIR));
> +ALLOW_DEPRECATED_DECLARATIONS_END
Let's remove the tests, since it does nothing in the end.
More information about the webkit-reviews
mailing list