[webkit-reviews] review denied: [Bug 198747] [WinCairo] Make objects used in CurlRequest thread safe. : [Attachment 371936] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 12 02:21:21 PDT 2019

Fujii Hironori <Hironori.Fujii at sony.com> has denied Takashi Komori
<Takashi.Komori at sony.com>'s request for review:
Bug 198747: [WinCairo] Make objects used in CurlRequest thread safe.

Attachment 371936: Patch


--- Comment #14 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 371936
  --> https://bugs.webkit.org/attachment.cgi?id=371936

View in context: https://bugs.webkit.org/attachment.cgi?id=371936&action=review

> Source/WebCore/ChangeLog:3
> +	   [WinCairo] Make objects used in CurlRequest thread safe.

This patch doen't "Make objects used in CurlRequest thread safe".

> Source/WebCore/ChangeLog:7
> +

Please add a description what you did.

> Source/WebCore/platform/network/curl/CurlRequest.cpp:611
> +    callClient([response = response.isolatedCopy()](CurlRequest& request,
CurlRequestClient& client) mutable {

You should replace this isolatedCopy with WTFMove in the future. Please add a
comment at the moment.

More information about the webkit-reviews mailing list