[webkit-reviews] review granted: [Bug 198736] [iOS] Idempotent text autosizing needs to react properly to viewport changes : [Attachment 371849] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 11 21:19:48 PDT 2019


zalan <zalan at apple.com> has granted Wenson Hsieh <wenson_hsieh at apple.com>'s
request for review:
Bug 198736: [iOS] Idempotent text autosizing needs to react properly to
viewport changes
https://bugs.webkit.org/show_bug.cgi?id=198736

Attachment 371849: Patch

https://bugs.webkit.org/attachment.cgi?id=371849&action=review




--- Comment #2 from zalan <zalan at apple.com> ---
Comment on attachment 371849
  --> https://bugs.webkit.org/attachment.cgi?id=371849
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371849&action=review

> Source/WebCore/css/StyleResolver.cpp:901
> +    if (!settings().textAutosizingEnabled() ||
!settings().textAutosizingUsesIdempotentMode())
> +	   return;
> +
> +    if (!hasTextChildren(element))
> +	   return;
> +
> +    if (style.textSizeAdjust().isNone())
> +	   return;
> +
> +    if (newAutosizeStatus.shouldSkipSubtree())
> +	   return;
> +

so much better


More information about the webkit-reviews mailing list