[webkit-reviews] review denied: [Bug 198747] [WinCairo] Make objects used in CurlRequest thread safe. : [Attachment 371898] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 11 19:54:42 PDT 2019
Fujii Hironori <Hironori.Fujii at sony.com> has denied Takashi Komori
<Takashi.Komori at sony.com>'s request for review:
Bug 198747: [WinCairo] Make objects used in CurlRequest thread safe.
https://bugs.webkit.org/show_bug.cgi?id=198747
Attachment 371898: Patch
https://bugs.webkit.org/attachment.cgi?id=371898&action=review
--- Comment #9 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 371898
--> https://bugs.webkit.org/attachment.cgi?id=371898
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=371898&action=review
> Source/WebCore/ChangeLog:8
> + Make CertificateInfo and NetworkLoadMetrics objects thread safe.
This patch doesn't "Make CertificateInfo and NetworkLoadMetrics objects thread
safe".
> Source/WebCore/platform/network/curl/CurlRequest.h:78
> + void setStartTime(const MonotonicTime& startTime) { m_requestStartTime =
startTime.isolatedCopy(); }
Looks so bad.
You should define a new struct for passing metrics information from the worker
thread to the main thread, and calculate responseEnd in the main thread in the
future.
> Source/WebCore/platform/network/curl/CurlResourceHandleDelegate.h:55
> void curlDidReceiveResponse(CurlRequest&, const CurlResponse&) final;
You should change "const CurlResponse&" to "CurlResponse&&" for consistency and
efficiency in the future.
> Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp:112
> + m_networkLoadMetrics = response.networkLoadMetrics;
I don't like this copy. I prefer the original code because it uses "&&".
More information about the webkit-reviews
mailing list