[webkit-reviews] review granted: [Bug 198767] Integrate scrollbar gestures for iOS : [Attachment 371878] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 11 14:40:40 PDT 2019
Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 198767: Integrate scrollbar gestures for iOS
https://bugs.webkit.org/show_bug.cgi?id=198767
Attachment 371878: Patch
https://bugs.webkit.org/attachment.cgi?id=371878&action=review
--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 371878
--> https://bugs.webkit.org/attachment.cgi?id=371878
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=371878&action=review
> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1758
> +static BOOL
_WKGestureRecognizerIsBuiltInScrollViewGestureRecognizer(UIGestureRecognizer
*recognizer)
Nit - isBuiltInScrollViewGestureRecognizer()?
We typically only put a WK or _WK prefix on API or SPI.
More information about the webkit-reviews
mailing list