[webkit-reviews] review granted: [Bug 198752] [WPE][GTK] Fix build with unified sources disabled : [Attachment 371845] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 198752: [WPE][GTK] Fix build with unified sources disabled
https://bugs.webkit.org/show_bug.cgi?id=198752

Attachment 371845: Patch

https://bugs.webkit.org/attachment.cgi?id=371845&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 371845
  --> https://bugs.webkit.org/attachment.cgi?id=371845
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371845&action=review

It looks like you considered forward-declarations in headers whenever possible,
which was the only thing that really needed to be reviewed here. Good, and
thanks!

> Source/WebKit/WebProcess/WebPage/wpe/WebPageWPE.cpp:32
> +#if HAVE(ACCESSIBILITY)
> +#include "WebPageProxy.h"
> +#endif

Just #include it always, adding guards only increases the odds of
configuration-dependent build failures and has almost zero benefit.

If it really deserves guards (it doesn't) then it would need to be #included in
a separate block, at the bottom.