[webkit-reviews] review granted: [Bug 198678] Add a quirk for washingtonpost.com and nytimes.com : [Attachment 371609] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 10 14:21:50 PDT 2019


Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 198678: Add a quirk for washingtonpost.com and nytimes.com
https://bugs.webkit.org/show_bug.cgi?id=198678

Attachment 371609: Patch

https://bugs.webkit.org/attachment.cgi?id=371609&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 371609
  --> https://bugs.webkit.org/attachment.cgi?id=371609
Patch

r=me

Given that this is more than just one site now, I think we need a follow-up bug
to reduce the scope and impact of this quirk.

Specifically, I'd recommend the following behavior: If we're on a site where
this quirk is enabled, make available a global function named openDatabase. If
the function is called with four arguments, and all arguments are null, then
return an empty object. Otherwise, throw an exception that says "WebSQL is not
enabled".


More information about the webkit-reviews mailing list