[webkit-reviews] review granted: [Bug 198718] Add visualization of touch action regions : [Attachment 371744] Patch

[bugzilla-daemon at webkit.org]

Antoine Quint <graouts at apple.com> has granted  review:
Bug 198718: Add visualization of touch action regions
https://bugs.webkit.org/show_bug.cgi?id=198718

Attachment 371744: Patch

https://bugs.webkit.org/attachment.cgi?id=371744&action=review




--- Comment #4 from Antoine Quint <graouts at apple.com> ---
Comment on attachment 371744
  --> https://bugs.webkit.org/attachment.cgi?id=371744
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371744&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:2769
> +	   { TouchAction::PinchZoom, "p-z"_s, { 16, 4.5 }, 249, 171, 80 },

Maybe "pinch" would be catchier here.

> Source/WebCore/rendering/RenderLayerBacking.cpp:2797
> +//	     imageContext.setShadow({ }, 2, Color(255, 255, 255, 200));

You should probably remove those commented lines before landing.