[webkit-reviews] review granted: [Bug 198710] Add support for WeakRef : [Attachment 371736] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 10 10:01:06 PDT 2019

Michael Saboff <msaboff at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 198710: Add support for WeakRef

Attachment 371736: Patch


--- Comment #2 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 371736
  --> https://bugs.webkit.org/attachment.cgi?id=371736

View in context: https://bugs.webkit.org/attachment.cgi?id=371736&action=review


> Source/JavaScriptCore/runtime/JSWeakObjectRef.cpp:2
> + * Copyright (C) 2015-2016 Apple, Inc. All rights reserved.

Update the copyright year.

> Source/JavaScriptCore/runtime/WeakRefConstructor.h:30
> +class  à : public InternalFunction {

Is there something wrong with the nam or encoding of the name of this class?

More information about the webkit-reviews mailing list