[webkit-reviews] review granted: [Bug 198713] [WPE][Qt] Port to new wpe_fdo_egl_exported_image API : [Attachment 371737] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 198713: [WPE][Qt] Port to new wpe_fdo_egl_exported_image API
https://bugs.webkit.org/show_bug.cgi?id=198713

Attachment 371737: Patch

https://bugs.webkit.org/attachment.cgi?id=371737&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 371737
  --> https://bugs.webkit.org/attachment.cgi?id=371737
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371737&action=review

> Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewBackend.cpp:212
> -    RELEASE_ASSERT(m_lockedImage == EGL_NO_IMAGE_KHR);
> +    RELEASE_ASSERT(m_lockedImage == nullptr);

!m_lockedImage

> Source/cmake/OptionsWPE.cmake:175
> -    pkg_check_modules(WPE_BACKEND_FDO REQUIRED wpebackend-fdo-1.0)
> +    pkg_check_modules(WPE_BACKEND_FDO REQUIRED "wpebackend-fdo-1.0 >=
1.3.0")

Could you use find_package(WPEBackend-fdo 1.3.0) instead? You will have to
change the INCLUDE_DIRS and LIBRARIES vars to WPEBACKEND_FDO_INCLUDE_DIRS and
WPEBACKEND_FDO_LIBRARIES. That would make QtWPE consistent with wpe and gtk.