[webkit-reviews] review granted: [Bug 198696] Drag starting state can get stuck even though the drag has ended : [Attachment 371693] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 198696: Drag starting state can get stuck even though the drag has ended
https://bugs.webkit.org/show_bug.cgi?id=198696

Attachment 371693: Patch

https://bugs.webkit.org/attachment.cgi?id=371693&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 371693
  --> https://bugs.webkit.org/attachment.cgi?id=371693
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371693&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6746
> +	   RELEASE_LOG(DragAndDrop, "Drag session willAnimateLiftWithAnimator:
%p (animation completion block fired)", session);

Nit - this is redundant in the case where finalPosition ==
UIViewAnimatingPositionStart. Maybe add this logging state as an `else` clause
of the `if (finalPosition == UIViewAnimatingPositionStart)` below?