[webkit-reviews] review granted: [Bug 198664] REGRESSION (r244182) [WK1]: Page updates should always scheduleCompositingLayerFlush() immediately : [Attachment 371626] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 7 17:28:06 PDT 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 198664: REGRESSION (r244182) [WK1]: Page updates should always
scheduleCompositingLayerFlush() immediately
https://bugs.webkit.org/show_bug.cgi?id=198664

Attachment 371626: Patch

https://bugs.webkit.org/attachment.cgi?id=371626&action=review




--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 371626
  --> https://bugs.webkit.org/attachment.cgi?id=371626
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371626&action=review

> Source/WebCore/page/RenderingUpdateScheduler.h:51
>      void scheduleRenderingUpdate();
> -    void scheduleCompositingLayerFlush();
> +    void scheduleImmediateRenderingUpdate();
> +    void schedulePerScreenRenderingUpdate();

Let's call these:

    void scheduleTimedRenderingUpdate();
    void scheduleImmediateRenderingUpdate();

    void scheduleRenderingUpdate();


More information about the webkit-reviews mailing list