[webkit-reviews] review granted: [Bug 198681] Extend quirks to emulate bold/italic/underline in hidden editable areas : [Attachment 371614] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 198681: Extend quirks to emulate bold/italic/underline in hidden editable
areas
https://bugs.webkit.org/show_bug.cgi?id=198681

Attachment 371614: Patch

https://bugs.webkit.org/attachment.cgi?id=371614&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 371614
  --> https://bugs.webkit.org/attachment.cgi?id=371614
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371614&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3125
> +static bool shouldSynthezieKeyEvents(WKContentView *contentView)
> +{
> +    if
(contentView.focusedElementInformation.shouldSynthesizeKeyEventsForEditing &&
contentView.hasHiddenContentEditable)
> +	   return true;
> +    return false;
> +}

It seems like this could just be a method like so:

- (BOOL)shouldSynthesizeKeyEvents
{
    return _focusedElementInformation.shouldSynthesizeKeyEventsForEditing &&
self.hasHiddenContentEditable;
}

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3145
> +    if (shouldSynthezieKeyEvents(self))

"Synthezie"