[webkit-reviews] review granted: [Bug 166620] [MSE][GStreamer] Avoid QUOTA_EXCEEDED_ERR when seeking to a buffered range just before the buffered one : [Attachment 371506] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Enrique Ocaña
<eocanha at igalia.com>'s request for review:
Bug 166620: [MSE][GStreamer] Avoid QUOTA_EXCEEDED_ERR when seeking to a
buffered range just before the buffered one
https://bugs.webkit.org/show_bug.cgi?id=166620

Attachment 371506: Patch

https://bugs.webkit.org/attachment.cgi?id=371506&action=review




--- Comment #11 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 371506
  --> https://bugs.webkit.org/attachment.cgi?id=371506
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371506&action=review

> Source/WebCore/ChangeLog:16
> +	   This patch is authored by iivlev <iivlev at productengine.com>

Given that in comment 10 you said that you had to change the conditions of the
patch, I think the fair thing here would be to say that "This patch is based on
one by..."

>
LayoutTests/media/media-source/media-source-append-before-last-range-no-quota-e
xceeded.html:20
> +	 for (var i = 0 ; i < timeRanges.length ; i++) {
> +	  if (i)
> +	   bufferedRanges += ', ';
> +	  bufferedRanges += timeRanges.start(i) + '...' + timeRanges.end(i);
> +	 }

This indentation here looks a bit "short"