[webkit-reviews] review granted: [Bug 198410] Web Inspector: Elements: print/rulers/compositing/paint navigation items shouldn't be visible if the inspected target doesn't have a PageAgent : [Attachment 371041] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 198410: Web Inspector: Elements: print/rulers/compositing/paint navigation
items shouldn't be visible if the inspected target doesn't have a PageAgent
https://bugs.webkit.org/show_bug.cgi?id=198410

Attachment 371041: Patch

https://bugs.webkit.org/attachment.cgi?id=371041&action=review




--- Comment #5 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 371041
  --> https://bugs.webkit.org/attachment.cgi?id=371041
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371041&action=review

>> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:50
>>	   
WI.settings.showShadowDOM.addEventListener(WI.Setting.Event.Changed,
this._showShadowDOMSettingChanged, this);
> 
> Does ITMLKit have an equivalent concept of "Shadow DOM", or should we be
hiding this when `WI.sharedApp.hasExtraDomains`?

I don't think they have shadow DOM.