[webkit-reviews] review granted: [Bug 198584] Allow WebKitTestRunner to terminate network process after it finishes service worker file operations : [Attachment 371451] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 198584: Allow WebKitTestRunner to terminate network process after it
finishes service worker file operations
https://bugs.webkit.org/show_bug.cgi?id=198584

Attachment 371451: Patch

https://bugs.webkit.org/attachment.cgi?id=371451&action=review




--- Comment #5 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 371451
  --> https://bugs.webkit.org/attachment.cgi?id=371451
Patch

Hmmm... I guess if we need to test network process crashes, that is a case
where we want to separate data flush from crash.

I don't think it's possible to wait for the data to be flushed; there's no way
to know when to stop waiting. We could add a short delay, but in the past that
approach has caused test flakiness on our bots. But maybe you have a suggestion
for how to wait?

I'll say r=me for now, but if you have a suggestion, we should consider it.