[webkit-reviews] review denied: [Bug 198589] Add --[no]-xcbuild to build-* scripts : [Attachment 371456] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 6 10:01:26 PDT 2019

Alexey Proskuryakov <ap at webkit.org> has denied Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 198589: Add --[no]-xcbuild to build-* scripts

Attachment 371456: Patch


--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 371456
  --> https://bugs.webkit.org/attachment.cgi?id=371456

View in context: https://bugs.webkit.org/attachment.cgi?id=371456&action=review

> Tools/ChangeLog:8
> +	   The --no-xcbuild flag is needed for ASan builds, and right now, only

There is a better way to fix ASan, discussed in person.

I don't think that we want to add more manual switches for the build system.
Since the old build system is deprecated, scripts should just automatically use
XCBuild wherever possible, and there needn't be a way to manually override,
except for the person who is working on XCBuild support (and they can do it
with a local patch).

There is indeed an undesirable behavior where run-webkit-tests ends up
rebuilding tools with XCBuild even though make didn't. This doesn't seem like a
pressing problem though, and it will resolve itself once everything is XCBuild.

More information about the webkit-reviews mailing list