[webkit-reviews] review granted: [Bug 198569] [GStreamer] AVC1 decoding capabilities probing support : [Attachment 371493] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 198569: [GStreamer] AVC1 decoding capabilities probing support
https://bugs.webkit.org/show_bug.cgi?id=198569

Attachment 371493: Patch

https://bugs.webkit.org/attachment.cgi?id=371493&action=review




--- Comment #8 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 371493
  --> https://bugs.webkit.org/attachment.cgi?id=371493
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371493&action=review

> Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:331
> +#define CHECK_H264_CAPS(capsString) do { \
> +    bool supported = false; \
> +    auto lookupResult = hasElementForMediaType(m_videoDecoderFactories,
capsString, true); \
> +    supported = lookupResult; \
> +    if (shouldCheckForHardwareUse) \
> +	   supported = lookupResult.isUsingHardware; \
> +    GST_DEBUG("%s decoding supported for codec %s: %s",
shouldCheckForHardwareUse ? "Hardware" : "Software", codec.utf8().data(),
boolForPrinting(supported)); \
> +    return supported; \
> +} while (0)

Creating and undeffing this macro looks a bit too convoluted to me. I'd either
create a lambda inside this function or a static just before.