[webkit-reviews] review granted: [Bug 198453] Reenable Gigacage on ARM64. : [Attachment 371488] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 6 05:38:11 PDT 2019
Michael Saboff <msaboff at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 198453: Reenable Gigacage on ARM64.
https://bugs.webkit.org/show_bug.cgi?id=198453
Attachment 371488: Patch
https://bugs.webkit.org/attachment.cgi?id=371488&action=review
--- Comment #12 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 371488
--> https://bugs.webkit.org/attachment.cgi?id=371488
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=371488&action=review
r=me with one comment.
> Source/JavaScriptCore/offlineasm/instructions.rb:276
> + "bfiq", # Bit field insert <source reg> <width immediate> <last bit
written> <dest reg>
The order of width and last bit written seem to be backwards.
More information about the webkit-reviews
mailing list