[webkit-reviews] review granted: [Bug 198597] Don't expose negative scrollLeft/scrollTop during rubber-banding : [Attachment 371468] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 198597: Don't expose negative scrollLeft/scrollTop during rubber-banding
https://bugs.webkit.org/show_bug.cgi?id=198597

Attachment 371468: Patch

https://bugs.webkit.org/attachment.cgi?id=371468&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 371468
  --> https://bugs.webkit.org/attachment.cgi?id=371468
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371468&action=review

> Source/WebCore/platform/ScrollView.h:224
> +    WEBCORE_EXPORT ScrollPosition scrollPosition(ScrollClamping =
ScrollClamping::Unclamped) const final;

Alternatively these functions could return both clamped and unclamped values as
a struct, avoiding parameter passing.