[webkit-reviews] review granted: [Bug 198106] WebAssembly: pow functions returns 0 when exponent 1.0 or -1.0 : [Attachment 371423] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 5 11:27:36 PDT 2019


Saam Barati <sbarati at apple.com> has granted Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 198106: WebAssembly: pow functions returns 0 when exponent 1.0 or -1.0
https://bugs.webkit.org/show_bug.cgi?id=198106

Attachment 371423: Patch

https://bugs.webkit.org/attachment.cgi?id=371423&action=review




--- Comment #13 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 371423
  --> https://bugs.webkit.org/attachment.cgi?id=371423
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371423&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:2462
> +	   m_assembler.fcsel<64>(dest, thenCase, elseCase,
ARM64Condition(cond));

Please also add a standalone testmasm test.


More information about the webkit-reviews mailing list