[webkit-reviews] review denied: [Bug 198551] Remove TestWebKitAPI from some configurations : [Attachment 371419] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Keith Rollin
<krollin at apple.com>'s request for review:
Bug 198551: Remove TestWebKitAPI from some configurations
https://bugs.webkit.org/show_bug.cgi?id=198551

Attachment 371419: Patch

https://bugs.webkit.org/attachment.cgi?id=371419&action=review




--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 371419
  --> https://bugs.webkit.org/attachment.cgi?id=371419
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371419&action=review

>> Tools/Makefile:7
>> +		ifeq (,$(findstring appletv,$(SDKROOT)))  # Don't build
TestWebKitAPI on AppleTV, due to missing SSL support
> 
> Alex, isn't this just your new test server? Can we just disable Alex's new
test server for Apple TV. Disabling building ALL tests seems aggressive.

We could either build libwebrtc's boringssl on AppleTV and link with it, or we
could just add preprocessor macros to all use of TCPServer in TestWebKitAPI.  I
agree, disabling all tests would be a bad thing.