[webkit-reviews] review granted: [Bug 198548] Use an enumeration in UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo callback : [Attachment 371370] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 198548: Use an enumeration in
UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo callback
https://bugs.webkit.org/show_bug.cgi?id=198548

Attachment 371370: Patch

https://bugs.webkit.org/attachment.cgi?id=371370&action=review




--- Comment #7 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 371370
  --> https://bugs.webkit.org/attachment.cgi?id=371370
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371370&action=review

> Source/WebKit/UIProcess/UserMediaPermissionCheckProxy.h:41
> +    enum class PermissionInfo { Error, NoAccess, PersistentAccess };

Nit: "NoAccess" isn't quite right, the user needs to be asked. Maybe
"RequirePrompt", or "PromptUser" instead?