[webkit-reviews] review granted: [Bug 198541] [ContentChangeObserver] Gmail text editing controls require two taps : [Attachment 371336] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 4 16:11:05 PDT 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 198541: [ContentChangeObserver] Gmail text editing controls require two
taps
https://bugs.webkit.org/show_bug.cgi?id=198541

Attachment 371336: Patch

https://bugs.webkit.org/attachment.cgi?id=371336&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 371336
  --> https://bugs.webkit.org/attachment.cgi?id=371336
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371336&action=review

> Source/WebCore/page/ios/ContentChangeObserver.cpp:98
> +	   return element.Element::willRespondToMouseClickEvents();

Ugh. Would it be nicer to add an argument to willRespondToMouseClickEvents()
saying whether it's for the touch callout?


More information about the webkit-reviews mailing list