[webkit-reviews] review granted: [Bug 198544] Fix miscellaneous build warnings : [Attachment 371340] Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 198544: Fix miscellaneous build warnings
https://bugs.webkit.org/show_bug.cgi?id=198544

Attachment 371340: Patch

https://bugs.webkit.org/attachment.cgi?id=371340&action=review




--- Comment #2 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 371340
  --> https://bugs.webkit.org/attachment.cgi?id=371340
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371340&action=review

r=me with nits

> Tools/TestWebKitAPI/PlatformGTK.cmake:110
> +set(TestJSC_SYSTEM_INCLUDE_DIRECTORIES
> +    ${GLIB_INCLUDE_DIRS}
> +    ${GTK3_INCLUDE_DIRS}
> +)
> +
>  set(TestJSC_PRIVATE_INCLUDE_DIRECTORIES
>      ${CMAKE_BINARY_DIR}
>      ${TESTWEBKITAPI_DIR}
> -    ${GLIB_INCLUDE_DIRS}
> -    ${GTK3_INCLUDE_DIRS}
>      ${THIRDPARTY_DIR}/gtest/include

This was copy pasted in PlatformWPE.cmake. this need updating as well?