[webkit-reviews] review granted: [Bug 198496] NetworkHTTPSUpgradeChecker should construct and destruct database on the background thread : [Attachment 371300] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 4 10:56:22 PDT 2019
Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 198496: NetworkHTTPSUpgradeChecker should construct and destruct database
on the background thread
https://bugs.webkit.org/show_bug.cgi?id=198496
Attachment 371300: Patch
https://bugs.webkit.org/attachment.cgi?id=371300&action=review
--- Comment #10 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 371300
--> https://bugs.webkit.org/attachment.cgi?id=371300
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=371300&action=review
> Source/WebKit/NetworkProcess/NetworkHTTPSUpgradeChecker.cpp:42
> +constexpr auto HTTPSUpgradeCheckerQuery = "SELECT host FROM hosts WHERE host
= ?"_s;
nit: httpsUpgradeCheckerQuery per WebKit coding style.
More information about the webkit-reviews
mailing list