[webkit-reviews] review granted: [Bug 198532] Sticky positioning is jumpy in many overflow cases : [Attachment 371290] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 4 10:18:57 PDT 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 198532: Sticky positioning is jumpy in many overflow cases
https://bugs.webkit.org/show_bug.cgi?id=198532

Attachment 371290: patch

https://bugs.webkit.org/attachment.cgi?id=371290&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 371290
  --> https://bugs.webkit.org/attachment.cgi?id=371290
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371290&action=review

> Source/WebCore/page/scrolling/cocoa/ScrollingTreeStickyNode.mm:89
> +		       auto overflowNode =
scrollingTree().nodeForID(positioningAncestor.relatedOverflowScrollingNodes()[0
]);

Are you guaranteed to have positioningAncestor.relatedOverflowScrollingNodes ?


More information about the webkit-reviews mailing list