[webkit-reviews] review granted: [Bug 198430] getUserMedia requests should be processed sequentially in UIProcess : [Attachment 371209] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 4 07:02:12 PDT 2019
Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 198430: getUserMedia requests should be processed sequentially in UIProcess
https://bugs.webkit.org/show_bug.cgi?id=198430
Attachment 371209: Patch
https://bugs.webkit.org/attachment.cgi?id=371209&action=review
--- Comment #7 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 371209
--> https://bugs.webkit.org/attachment.cgi?id=371209
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=371209&action=review
> Source/WebKit/ChangeLog:9
> + getUserMedia requests should be processed sequentially in UIProcess
> + https://bugs.webkit.org/show_bug.cgi?id=198430
> + <rdar://problem/51311420>
> +
> + Reviewed by NOBODY (OOPS!).
> +
> + * UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
Oops - double Changelogs.
> Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:378
> + if (m_currentUserMediaRequest != request)
> return;
How can this happen? It is probably worth logging an error if this should never
happen.
> Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:400
> + if (!weakThis || m_currentUserMediaRequest != request)
Ditto.
> Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:404
> + if (!weakThis || m_currentUserMediaRequest != request)
Ditto.
> Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:414
> + if (!weakThis || m_currentUserMediaRequest != request)
Ditto.
More information about the webkit-reviews
mailing list