[webkit-reviews] review granted: [Bug 198488] [iOS] Do not prevent app suspension for more than 20 seconds after getting backgrounded : [Attachment 371194] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 198488: [iOS] Do not prevent app suspension for more than 20 seconds after
getting backgrounded
https://bugs.webkit.org/show_bug.cgi?id=198488

Attachment 371194: Patch

https://bugs.webkit.org/attachment.cgi?id=371194&action=review




--- Comment #5 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 371194
  --> https://bugs.webkit.org/attachment.cgi?id=371194
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371194&action=review

r=me

> Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:236
> +    [self _cancelPendingReleaseTask];
> +    [self _cancelTimeoutTask];

Naming inconsistency is a little annoying here. 

I think the right naming is probabaly

    _cancelPendingReleaseTask => _cancelReleaseTask
    _pendingReleaseTask => _releaseTask
    _pendingTimeoutTask => _timeoutTask