[webkit-reviews] review granted: [Bug 198434] REGRESSION (r245913) [ Debug ] ASSERTION FAILED: m_swConnectionsByIdentifier.contains(connection.serverConnectionIdentifier()) Layout Test http/wpt/service-workers/update-service-worker.https.html is a flaky crash : [Attachment 371094] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 198434: REGRESSION (r245913) [ Debug ] ASSERTION FAILED:
m_swConnectionsByIdentifier.contains(connection.serverConnectionIdentifier())
Layout Test http/wpt/service-workers/update-service-worker.https.html is a
flaky crash
https://bugs.webkit.org/show_bug.cgi?id=198434

Attachment 371094: Patch

https://bugs.webkit.org/attachment.cgi?id=371094&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 371094
  --> https://bugs.webkit.org/attachment.cgi?id=371094
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371094&action=review

> Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:198
> +    auto connections = WTFMove(m_swConnectionsByIdentifier);

This feels like more of a std::exchange kind of use.