[webkit-reviews] review denied: [Bug 198496] NetworkHTTPSUpgradeChecker database is accessed from multiple threads : [Attachment 371210] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 198496: NetworkHTTPSUpgradeChecker database is accessed from multiple
threads
https://bugs.webkit.org/show_bug.cgi?id=198496

Attachment 371210: Patch

https://bugs.webkit.org/attachment.cgi?id=371210&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 371210
  --> https://bugs.webkit.org/attachment.cgi?id=371210
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371210&action=review

> Source/WebKit/NetworkProcess/NetworkHTTPSUpgradeChecker.cpp:70
> +	   m_database = std::make_unique<SQLiteDatabase>();

Also, now these get constructed on the background queue but still destroyed on
the main thread, which may not be safe.