[webkit-reviews] review granted: [Bug 198395] Web Inspector: remove RemoteObject.prototype.getPropertyDescriptorsAsObject : [Attachment 371033] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 3 13:18:49 PDT 2019
Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 198395: Web Inspector: remove
RemoteObject.prototype.getPropertyDescriptorsAsObject
https://bugs.webkit.org/show_bug.cgi?id=198395
Attachment 371033: Patch
https://bugs.webkit.org/attachment.cgi?id=371033&action=review
--- Comment #9 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 371033
--> https://bugs.webkit.org/attachment.cgi?id=371033
Patch
r=me, nice fix.
Since ErrorObjectView.prototype.update is only called internally, and isn't an
override, let's make it private or even inline it inside
ErrorObjectView.prototype.expand, which is the only call site.
More information about the webkit-reviews
mailing list