[webkit-reviews] review granted: [Bug 198469] Memory-cached main resources continue to load after the client decides a content policy of PolicyAction::Download : [Attachment 371167] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 3 08:57:42 PDT 2019


youenn fablet <youennf at gmail.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 198469: Memory-cached main resources continue to load after the client
decides a content policy of PolicyAction::Download
https://bugs.webkit.org/show_bug.cgi?id=198469

Attachment 371167: Patch

https://bugs.webkit.org/attachment.cgi?id=371167&action=review




--- Comment #7 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 371167
  --> https://bugs.webkit.org/attachment.cgi?id=371167
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371167&action=review

> Source/WebCore/loader/DocumentLoader.cpp:953
> +	   ASSERT(m_mainResource);

Is this assert needed given we check for m_mainResource at the beginning of the
Download case block?


More information about the webkit-reviews mailing list