[webkit-reviews] review denied: [Bug 198466] [WinCairo] Layout tests related to inspector doesn't work. : [Attachment 371142] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has denied Takashi Komori
<Takashi.Komori at sony.com>'s request for review:
Bug 198466: [WinCairo] Layout tests related to inspector doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=198466

Attachment 371142: Patch

https://bugs.webkit.org/attachment.cgi?id=371142&action=review




--- Comment #2 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 371142
  --> https://bugs.webkit.org/attachment.cgi?id=371142
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371142&action=review

> Source/WebCore/PlatformWinCairo.cmake:16
> +    page/win/ResourceUsageThreadWinCairo.cpp

Rename *Win.cpp.

> Source/WebCore/page/win/ResourceUsageThreadWinCairo.cpp:43
> +uint64_t fileTimeToUint64(FILETIME ft)

Mark these file-local functions "static".

> Tools/WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:-40
> -    return JSStringCreateWithUTF8CString("");

What about using UrlCreateFromPath?
https://docs.microsoft.com/en-us/windows/desktop/api/shlwapi/nf-shlwapi-urlcrea
tefrompatha

> Tools/WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:44
> +	   _wsplitpath(exePath, drive, dir, nullptr, nullptr);

Why do you need to split first?

> Tools/WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:52
> +	   char stubPathUTF8[MAX_PATH];

MAX_PATH shouldn't be used for UTF-8 buffer length. How about using
JSStringCreateWithCharacters? Then, you don't need to convert to UTF-8.

> LayoutTests/platform/wincairo/TestExpectations:1566
>  inspector [ Skip ]

Can you unskip all inspector tests? How much failure will occur? If you can't
unskip inspector tests, I think you should change the summary of this bug.