[webkit-reviews] review granted: [Bug 200296] Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'issueMessage.sourceCodeLocation.sourceCode') : [Attachment 375217] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 200296: Web Inspector: Uncaught Exception: TypeError: null is not an object
(evaluating 'issueMessage.sourceCodeLocation.sourceCode')
https://bugs.webkit.org/show_bug.cgi?id=200296

Attachment 375217: Patch

https://bugs.webkit.org/attachment.cgi?id=375217&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 375217
  --> https://bugs.webkit.org/attachment.cgi?id=375217
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375217&action=review

r=me

> Source/WebInspectorUI/ChangeLog:10
> +	   we should pass the `WI.SourceCode` along in that case, and use it
when creating a associated

Grammar: "a associate" => "an association"

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:1407
> +	   if (!sourceCode && !issueMessage.sourceCodeLocation)
> +	       return null;

Can this ever happen? Could this just become an assert.

Seems the `debuggerObject` case is the only time this could happen.