[webkit-reviews] review granted: [Bug 200248] Owners of MultiChannelResampler should make sure that the output bus given to it has the same number of channels : [Attachment 375179] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 31 05:36:52 PDT 2019


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 200248: Owners of MultiChannelResampler should make sure that the output
bus given to it has the same number of channels
https://bugs.webkit.org/show_bug.cgi?id=200248

Attachment 375179: Patch

https://bugs.webkit.org/attachment.cgi?id=375179&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 375179
  --> https://bugs.webkit.org/attachment.cgi?id=375179
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375179&action=review

> Source/WebCore/ChangeLog:9
> +	   When a track number of channels is changing,
MediaStreamAudioSourceNode is expected

Nit: s/track number of channels is changing/track's number of channels changes/

> Source/WebCore/ChangeLog:11
> +	   MultiChannelResampler expects to have the same amount of channels as
the output

Nit: s/amount/number/


More information about the webkit-reviews mailing list