[webkit-reviews] review granted: [Bug 200283] Element.outerHTML is missing attribute prefixes in some cases in HTML documents : [Attachment 375194] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 200283: Element.outerHTML is missing attribute prefixes in some cases in
HTML documents
https://bugs.webkit.org/show_bug.cgi?id=200283

Attachment 375194: Patch

https://bugs.webkit.org/attachment.cgi?id=375194&action=review




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 375194
  --> https://bugs.webkit.org/attachment.cgi?id=375194
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375194&action=review

> Source/WebCore/editing/MarkupAccumulator.cpp:562
> +	       AtomStringImpl* foundNS = namespaces &&
attribute.prefix().impl() ? namespaces->get(attribute.prefix().impl()) : 0;

I know you're just moving code around but maybe use nullptr?

> Source/WebCore/editing/MarkupAccumulator.cpp:565
> +		   if (AtomStringImpl* prefix = namespaces ?
namespaces->get(attribute.namespaceURI().impl()) : 0)

Ditto.