[webkit-reviews] review denied: [Bug 191498] [Curl] implement CertificateInfo::summaryInfo : [Attachment 375068] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 30 22:04:02 PDT 2019

Fujii Hironori <Hironori.Fujii at sony.com> has denied Takashi Komori
<Takashi.Komori at sony.com>'s request for review:
Bug 191498: [Curl] implement CertificateInfo::summaryInfo

Attachment 375068: Patch


--- Comment #34 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 375068
  --> https://bugs.webkit.org/attachment.cgi?id=375068

View in context: https://bugs.webkit.org/attachment.cgi?id=375068&action=review

> Source/WebCore/platform/network/curl/OpenSSLHelper.cpp:46
> +using X509Ref = std::unique_ptr<X509, deleter<X509>>;

I don't think X509Ref is a good name because this is not ref-counted object and
this can be nullptr.
I think you don't need to type aliasing becuase this type is used only once.

> Source/WebCore/platform/network/curl/OpenSSLHelper.cpp:138
> +	   if (auto x509 = ::PEM_read_bio_X509(m_bio, nullptr, 0, nullptr))

return X509Ref(::PEM_read_bio_X509(m_bio, nullptr, 0, nullptr));

> Source/WebCore/platform/network/curl/OpenSSLHelper.cpp:184
> +    return WTFMove(result);

You should remove WTFMove.
return result;

> Source/WebCore/platform/network/curl/OpenSSLHelper.cpp:205
> +    auto commonName = toString(commonNameEntryData);

How about simply returning the return value of toString?
return toString(commonNameEntryData);

More information about the webkit-reviews mailing list